Fix concurrency bug in ScopedAtomicFactory#778
Merged
Conversation
added 3 commits
April 18, 2026 19:11
|
coverage: 99.021% (-0.09%) from 99.11% — users/alexpeck/scopedatomconc into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a volatile read, see equivalent code for ScopedAsyncAtomicFactory:
BitFaster.Caching/BitFaster.Caching/Atomic/ScopedAsyncAtomicFactory.cs
Line 120 in 689f263
Issue was exposed via new soak tests in #771. This shows there is also a test gap.
Without the volatile read, the JIT will optimize away the copy. Fixed the same issue in the dispose code path.